Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP_HUGE_SHIFT & HUGETLB_FLAG_ENCODE_SHIFT for Andorid/Fuchsia #3444

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

SteveLauC
Copy link
Contributor

Add these 2 constants for Android and Fuchsia

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Nov 22, 2023

📌 Commit 8605ce1 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 22, 2023

⌛ Testing commit 8605ce1 with merge 1578c5a...

bors added a commit that referenced this pull request Nov 22, 2023
MAP_HUGE_SHIFT & HUGETLB_FLAG_ENCODE_SHIFT for Andorid/Fuchsia

Add these 2 constants for Android and Fuchsia
@bors
Copy link
Contributor

bors commented Nov 22, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Nov 22, 2023

⌛ Testing commit 8605ce1 with merge 51a2c32...

bors added a commit that referenced this pull request Nov 22, 2023
MAP_HUGE_SHIFT & HUGETLB_FLAG_ENCODE_SHIFT for Andorid/Fuchsia

Add these 2 constants for Android and Fuchsia
@bors
Copy link
Contributor

bors commented Nov 22, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Failed on i686-android:

error[E0412]: cannot find type `c_int` in this scope
    --> src/unix/linux_like/android/mod.rs:3323:38
     |
3323 | pub const HUGETLB_FLAG_ENCODE_SHIFT: c_int = 26;
     |                                      ^^^^^ not found in this scope
     |
help: consider importing one of these items
     |
3903 +         use c_int;
     |
3903 +         use ffi::c_int;
     |

error[E0412]: cannot find type `c_int` in this scope
    --> src/unix/linux_like/android/mod.rs:3324:27
     |
3324 | pub const MAP_HUGE_SHIFT: c_int = HUGETLB_FLAG_ENCODE_SHIFT;
     |                           ^^^^^ not found in this scope
     |
help: consider importing one of these items
     |
3903 +         use c_int;
     |
3903 +         use ffi::c_int;

@rustbot author

@SteveLauC
Copy link
Contributor Author

Oops, I am sorry about this, fixed!

@JohnTitor
Copy link
Member

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Dec 1, 2023

📌 Commit b20eccc has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 1, 2023

⌛ Testing commit b20eccc with merge 497ac42...

@bors
Copy link
Contributor

bors commented Dec 1, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 497ac42 to main...

@bors bors merged commit 497ac42 into rust-lang:main Dec 1, 2023
11 checks passed
@SteveLauC SteveLauC deleted the map_huge_shift branch December 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants